edgi-govdata-archiving / archivers.space

🗄 Event data management app used at DataRescues
https://www.archivers.space/
GNU Affero General Public License v3.0
6 stars 3 forks source link

Need to suppress/resolve Meteor warnings in console #10

Closed kmcculloch closed 7 years ago

kmcculloch commented 7 years ago

From @b5 on February 2, 2017 13:40

Just looks bad to all our friends who start to poke around with the app :)

Copied from original issue: b5/pipeline#19

kmcculloch commented 7 years ago

Assuming that these are the warnings in question:

"WARNING: npm peer requirements not installed:

Read more about installing npm peer dependencies: http://guide.meteor.com/using-packages.html#peer-npm-dependencies "

This took a crapload of grepping to track down. First of all, the error itself isn't generated out of a package.json in any of the dependencies, but via a plugin:

https://github.com/tmeasday/check-npm-versions/blob/master/check-npm-versions.js

The package with the offending "checkNpmVersions" call is react-runtime:

https://github.com/meteor/react-packages/blob/react%400.14.6/packages/react-runtime/react-runtime.js

This nonsense goes away on the 15.0.0 branch of that package:

https://github.com/meteor/react-packages/blob/react%4015.0.0/packages/react-runtime/react-runtime.js

So I installed it:

meteor add react-runtime@15.0.0 --allow-incompatible-update

...and committed the new .meteor package info to a new branch, peer-dependency-errors. So far the app is running on my localhost without the annoying log messages and without any (new) errors. This did cause a couple of other changes to the meteor package specifications that @b5 or someone with more advanced meteor knowledge should review.