search

edgi-govdata-archiving / archivers.space

🗄 Event data management app used at DataRescues
https://www.archivers.space/
GNU Affero General Public License v3.0
6 stars 3 forks source link

Bump url limit above 30 and deploy #83

Closed patcon closed 7 years ago

patcon commented 7 years ago

In Toronto, @dcwalk and I have been filtering on "epa.gov" in order to understand how many urls we have left. but I just realized it's capped at 30 urls: https://github.com/edgi-govdata-archiving/archivers.space/tree/master/imports/ui/containers/pages/UrlList.js#L105

@b5 any reason I couldn't bump that and redeploy? :slightly_smiling_face:

cc: @mattprice who was rightfully suspicious of the url count :wink:

b5 commented 7 years ago

sure thing, looking forward to a one-line PR ;)

patcon commented 7 years ago

Ready for: review/merge/rocketships!

patcon commented 7 years ago

bump @b5 :)

Also, might this be something I could deploy myself? Sorry, should have pinged you earlier, but had been idly hoping to have this deployed by tonight's hacknight so we could have some clear goals working in v1 :)

Any help appreciated!

b5 commented 7 years ago

Ugh sorry about the delay. Lots of stuff flying around these days :)

As for deployment, All of the services the archiving working group maintains will are based on CI (continuous integration), so deploying everything in the "2.0 world" is just pushing a passing version to the master branch.

Unfortunately this repo falls under the "legacy" category, and has a special deploy method that I don't think we should spend the cycles as we're slowly phasing out support.

dcwalk commented 7 years ago

Hey, just chiming in-- when you say all archiving working group repos are deploy from master-- which ones are that currently? I don't think we've done a good job of documenting, and from what I understand maybe just 1 of the web-monitoring is? Maybe we could add a deployment section to the readme

b5 commented 7 years ago

very good idea, I should have also communicated more clearly here, when I say "archive working group", I should have said archivers 2.0 stuff. Repos use circle CI and publish here if tests pass: https://hub.docker.com/u/archivers/dashboard/

by deployment do we mean the readme for this repo? Maybe that could mean all repos...

dcwalk commented 7 years ago

I can't check out that dashboard @b5 -- is there a way to add people to the archivers docker team? (also, we should document this in services doc!)

There are deployment details in a few other repos, we've not been consistent (but should be!) In this case I meant the current repo and any archivers repos that are deploying from master...?

b5 commented 7 years ago

whoops, bad url: https://hub.docker.com/u/archivers/

We can totally add others to the docker hub, I see very little need to, as all the images are public and don't originate on docker, but would be happy to set that up if others so desire!

As for deployment details for this repo, I'd welcome a PR that adds info (@kmcculloch would be a great person to ask for details), but can't get to it myself in the near future.

patcon commented 7 years ago

With the issue at hand: Matt and I are prepping for hacknight tonight, and your deploy will be really really helpful in making the process more transparent! Thanks man!