search

edgi-govdata-archiving / edgi-hubot-halpy

Heroku-backed chatbot-friend who lives in EDGI Slack
https://edgi-hubot.herokuapp.com/
3 stars 0 forks source link

WIP: Do Not Merge -- Update to Hubot 3 & Zoom API 2 #40

Open titaniumbones opened 5 years ago

titaniumbones commented 5 years ago

This branch updates Hubot to version 3 and changes the Zoom script to use Zoom API v2. It also adds a few new commands, and should be the basis for future development, but it's not ready for deployment yet.

titaniumbones commented 5 years ago

pinging @patcon b/c there is a licensing hcange here and I wnat to be sure you're cool with it, and @lightandluck because ultimately I htink the decision of whether to try using this new branch would be in your hands.

lightandluck commented 5 years ago

Thanks, Matt! I'll play around with this next week

patcon commented 5 years ago

This looks rad, @titaniumbones, particularly the docs and the new commands! Added some casual comments on some scaffold stuff.

What's the licensing change btw?

titaniumbones commented 5 years ago

@patcon thx for the comments. Man code review is so helpful!

Addressed everything but the node engine value -- see above, what do you think I should put there? Doesn't appear to be enforced as I'm using node 8.11 here!

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.

dcwalk commented 5 years ago

This seems potentially able to do some quick review and merge...?

patcon commented 5 years ago

@titaniumbones If the report request script in here was merged, would it still be valid, or would it be noise of an old process?