search

edgi-govdata-archiving / eot-nomination-tool

📚 Chrome extension to nominate government data that needs to be preserved
https://chrome.google.com/webstore/detail/nominationtool/abjpihafglmijnkkoppbookfkkanklok
GNU General Public License v3.0
20 stars 10 forks source link

Cut down option markup by 50% by dropping values #32

Closed atesgoral closed 7 years ago

sonalranjit commented 7 years ago

These changes were giving me error when i tried to submit on this url @atesgoral would you mind checking it out? other commits are succesfully working and submitting.

atesgoral commented 7 years ago

@sonalranjit I'll retest. Did you happen to capture what the error you were getting was?

atesgoral commented 7 years ago

@sonalranjit I've tested it locally and everything seems fine. I was initially getting an error, but that was due to a CORS failure while testing the popup off a local server.

mi-lee commented 7 years ago

Same as Sonal - got a 400 with this github link (i.e. this repo) but it's fine for other links. @titaniumbones I think it should be fine to merge.

atesgoral commented 7 years ago

So, you were getting a 400 Bad Request response from GitHub?

mi-lee commented 7 years ago

From Google Forms.

atesgoral commented 7 years ago

@mi-lee Can you tell me the exact values you're using in the tool?

atesgoral commented 7 years ago

@sonalranjit Are you able to reproduce the issue you saw? What exact values did you use? I see no reason for this markup simplification + proper use of jQuery's .val() to change the behaviour.

titaniumbones commented 7 years ago

hey are we good to merge this, sorry to have been so far behind on this...

atesgoral commented 7 years ago

@mi-lee, @sonalranjit bump