Closed sonalranjit closed 7 years ago
@ambergman @trinberg can you guys confirm that this is what you want, maybe by downloading the branch and testing the ui?
(Am already in bed w computer closed, so don't do it myself tonight)
Won't not don't.
from @trinberg :
REPLACE "Visualization" text with "Visualization/Interactive"
REPLACE "Complex/Hard" text with "Many Files"
ADD checkbox field with a header "Database"
@ambergman and I think the comment field is useful, but the added cost is that it makes the extension too big and produces the scrollbar. For now, I'd suggest:
REMOVE "comment" header and comment input box
Regarding formatting: If possible, keep the chrome extension as small in height as possible - the scrollbar can be difficult on certain machines/browsers.
I added the additional field they wanted, made some CSS changes to permit the Comment field to show up without scrolling. Looks like everything works, so I'm going to commit, though @sonalranjit @trinberg may want to follow up to make sure it's all good.
@titaniumbones just reviewed your push, looks great ready to merge. Thanks for expanding the width and the css. Whoever is merging this please rebase and merge. Also once this is merged we need to update the master branch with this version. I requested the pull request to be onto harvard-edgi because that was the most recent/updated branch.
by rebase do you mean squash or something more complicated? if just squashing I'll do it now.
On 02/01/2017 08:24 AM, Sonal Ranjit wrote:
@titaniumbones https://github.com/titaniumbones just reviewed your push, looks great ready to merge. Thanks for expanding the width and the css. Whoever is merging this please rebase and merge. Also once this is merged we need to update the master branch with this version. I requested the pull request to be onto harvard-edgi because that was the most recent/updated branch.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/edgi-govdata-archiving/presidential-harvest-nomination-tool/pull/39#issuecomment-276655992, or mute the thread https://github.com/notifications/unsubscribe-auth/AAWPNBMQ3b0SOIMUm7ZkL3OL1MOLqavzks5rYId2gaJpZM4LzeZ6.
Just the third option from the dropdown. @titaniumbones
oh sweet, I'll rebase both branches.
On 02/01/2017 08:30 AM, Sonal Ranjit wrote:
screen shot 2017-02-01 at 8 29 36 am https://cloud.githubusercontent.com/assets/12193813/22508575/979a3fba-e858-11e6-9b82-d2fde6423bc5.png Just the third option from the dropdown. @titaniumbones https://github.com/titaniumbones
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/edgi-govdata-archiving/presidential-harvest-nomination-tool/pull/39#issuecomment-276657238, or mute the thread https://github.com/notifications/unsubscribe-auth/AAWPNLS7l8tl03NDWtJ44wd8EUTISaMQks5rYIjpgaJpZM4LzeZ6.
Applied changes requested in #38