Extension missing Subprimer ID Field and Comment Field Status

[trinberg]

@titaniumbones @sonalranjit @dcwalk - Hi All. The extension works nicely - I just tested the new checkboxes. Thanks so much for your swift work!

I see two quite important changes that need to be made, though:

• The "Subprimer ID" field was removed and we definitely want to be able to record it. Can you ADD a text entry field for Subprimer ID as before, with the associated text "Sub-Primer Num" on the same row in the UI as the other Agency Office Code fields
• Seems like the "Comment" field is required now and the extension will not submit unless it's filled in . Can you make that an OPTIONAL field.

And is there any chance that can get done before 430? Thanks so much.

[sonalranjit]

working on it

[titaniumbones]

thx sonalr, sorry about the error, I thought I'd confirmed the subprimer, must have been tired.

On 02/01/2017 11:16 AM, Sonal Ranjit wrote:

working on it

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/edgi-govdata-archiving/presidential-harvest-nomination-tool/issues/42#issuecomment-276701454, or mute the thread https://github.com/notifications/unsubscribe-auth/AAWPNDOwtqW39aOFJELA22GgStFO3uMlks5rYK_XgaJpZM4L0DaZ.

[sonalranjit]

Updated it, ran few test submissions, seems to be working. Please conform and merge #43 @titaniumbones @trinberg

[trinberg]

@sonalranjit - can the subprimer field be on the same row as the agency office code? And the checkboxes be all on their own row as well? It seems like there's enough room now that it's wider. The UI looks jumbled as it is now.

[titaniumbones]

it's a bit annoying, I can futz w/ it if you want @sonalranjit or if you try I think the trick wd be to keep the label for subprimer higher than the agency id inputs, and float it right. Inputs would need to be cleared obvs.

On 02/01/2017 11:45 AM, trinberg wrote:

@sonalranjit https://github.com/sonalranjit - can the subprimer field be on the same row as the agency office code? And the checkboxes be all on their own row as well? It seems like there's enough room now that it's wider. The UI looks jumbled as it is now.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/edgi-govdata-archiving/presidential-harvest-nomination-tool/issues/42#issuecomment-276710290, or mute the thread https://github.com/notifications/unsubscribe-auth/AAWPNKWgagpQWBITWwe7-x9YvFOw0Vgfks5rYLadgaJpZM4L0DaZ.

[titaniumbones]

(let me know if you want me to do it, or if you have time in the next couple of hours).

[sonalranjit]

on it

[sonalranjit]

taking a bit long than anticipated, have to get back to work, I duno if you can handle this one @titaniumbones

[titaniumbones]

fixed, pushed, merged, upversioned.

[trinberg]

awesome - thanks! will get back to you with feedback after the event