edgi-govdata-archiving / eot-nomination-tool

📚 Chrome extension to nominate government data that needs to be preserved
https://chrome.google.com/webstore/detail/nominationtool/abjpihafglmijnkkoppbookfkkanklok
GNU General Public License v3.0
20 stars 10 forks source link

ES6 not supported in older browsers #66

Closed mi-lee closed 7 years ago

mi-lee commented 7 years ago

See https://github.com/edgi-govdata-archiving/eot-nomination-tool/blob/master/popup.js#L3

I'm getting emails from a user with an older version of chrome.

chromejavascripterror3 selection_008

atesgoral commented 7 years ago

Maybe just adding a 'use strict'; at the top of the file could resolve the above issue.

Beyond ES6, I'm now worried about my use of CSS flexbox...

mi-lee commented 7 years ago

Errr.... yeah, we shouldn't be using flexbox. Accessibility >>> convenience for a tool like this

mi-lee commented 7 years ago

use strict would solve that particular user's issue but given the tiny scope of this project and need for accessibility I'm opting to just go for the added minor inconvenience of switching to ES5

atesgoral commented 7 years ago

Fixed by #67