search

edgi-govdata-archiving / overview

šŸŽˆ Start here for current projects, how to get involved, and joining community calls, a resource for new and veteran members
GNU General Public License v3.0
118 stars 20 forks source link

Add a bot that explains our "it's ok to merge after X time without review" policy #238

Closed Frijol closed 4 years ago

Frijol commented 4 years ago

EDGI (or at least web monitoring) typically has an "ok to merge" policy for any straightforward PR that hasn't gotten reviews after 3 days. It would be nice to have a bot call this out on PRs that sit for 3 days without any interaction. (Otherwise the contributor might not be aware of this policy)

Mr0grog commented 4 years ago

For web monitoring, at least, I donā€™t think we really have many contributors with commit rights, so it feels like itā€™s easy enough to teach people this when giving them commit rights.

But also: I have stopped following this policy much of the time for the past several months (though I did talk that through with other contributors). Because we have so few active contributors, the policy mostly just adds delay. I still adhere to it if I donā€™t feel exceedingly confident (it forces me to ā€œsleep on itā€ and review again with a clearer head) or if Iā€™m working in an area where other contributors are really active (parts of web-monitoring-ui and wayback).

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.