search

edgi-govdata-archiving / version-tracking-ui

ARCHIVED--Bookmarklet to modify UI for Versionista website monitoring
MIT License
3 stars 1 forks source link

include source code of bookmarklet #7

Closed titaniumbones closed 7 years ago

titaniumbones commented 7 years ago

will be useful if we want to make changes later on & @jpmckinney isn't available. Also if e.g. @geppy wants to make a chrome extension.

jpmckinney commented 7 years ago

It's already in https://github.com/edgi-govdata-archiving/version-tracking-ui/blob/gh-pages/browser-tool.js

jpmckinney commented 7 years ago

Or, rather, you can go to https://edgi-govdata-archiving.github.io/version-tracking-ui/ and copy the bookmarklet.

titaniumbones commented 7 years ago

I just thought it might be nice to have as a separate file. Maybe I'm being silly. I guess is beter to hack in place & use the gh-pages generated site to test changes.

On 01/26/2017 11:34 PM, James McKinney wrote:

It's already in https://github.com/edgi-govdata-archiving/version-tracking-ui/blob/gh-pages/browser-tool.js

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/edgi-govdata-archiving/version-tracking-ui/issues/7#issuecomment-275587214, or mute the thread https://github.com/notifications/unsubscribe-auth/AAWPNIfKqpvg5VJ9xj5BR_c1gBCuHYOiks5rWXPTgaJpZM4Lvatl.

jpmckinney commented 7 years ago

It becomes a maintenance issue: the code should only be in one place, otherwise we have to carefully keep it in sync. Someone could probably rig up a npm run build that merges the code from a separate file, but seems unnecessary.

titaniumbones commented 7 years ago

Agreed, documenting source instead, as you've done, seems better.

On January 27, 2017 12:00:11 AM EST, James McKinney notifications@github.com wrote:

It becomes a maintenance issue: the code should only be in one place, otherwise we have to carefully keep it in sync. Someone could probably rig up a npm run build that merges the code from a separate file, but seems unnecessary.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/edgi-govdata-archiving/version-tracking-ui/issues/7#issuecomment-275589449

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.