edgi-govdata-archiving / wayback

A Python API to the Internet Archive Wayback Machine
https://wayback.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
61 stars 12 forks source link

Do PyPI release in GHA #155

Closed danielballan closed 8 months ago

danielballan commented 8 months ago

Precisely following https://learn.scientific-python.org/development/guides/gha-pure/

This introduces GHA, alongside CircleCI. An additional integration is not ideal, bu there are points in favor:

Mr0grog commented 8 months ago

That did not seem to make the workflow run here. It might just need to land in this repo (and not a fork) before it be run, or GH has to see some workflows in this repo before it understands that the workflow engine should kick in.

Anyway, I’m cool to ship this if you think it’s good, assuming I got the above stuff about intended usage correct.

danielballan commented 8 months ago

I think I've seen this before: GH will not run a new workflow on a PR branch.

Yes, that summary of the intended usage is precisely right.

I have just pushed a commit to remove the build section from the CircleCI config.