Multiple API endpoints use HTTP instead of HTTPS

edgi-govdata-archiving / wayback

A Python API to the Internet Archive Wayback Machine

https://wayback.readthedocs.io/en/stable/

BSD 3-Clause "New" or "Revised" License

65 stars 12 forks source link

Multiple API endpoints use HTTP instead of HTTPS #81

Closed sundhaug92 closed 2 years ago

sundhaug92 commented 3 years ago

Ex:

https://github.com/edgi-govdata-archiving/wayback/blob/024a80ec0eae44fcf64e3d834d5f43c78937b8fb/wayback/_models.py#L253
https://github.com/edgi-govdata-archiving/wayback/blob/024a80ec0eae44fcf64e3d834d5f43c78937b8fb/wayback/_client.py#L48
https://github.com/edgi-govdata-archiving/wayback/blob/024a80ec0eae44fcf64e3d834d5f43c78937b8fb/wayback/_client.py#L58

Note: Fixing this may require changing the mocks

Mr0grog commented 3 years ago

Ah! This is because the memento URLs used to redirect from https to http (very surprising, which is why I remember it!). It looks like that’s changed, though, so we should probably make everything HTTPS. Thanks! 👍

I’m also happy to accept a PR if you’d like to make the change.