Closed dependabot[bot] closed 4 months ago
@dependabot rebase
Putting this on ice for now, but once I get around to solving some other actual-release-related issues (e.g. #145, #165) this is worth coming back to.
From the release notes and migration guide, it looks like there are some changes that need some deeper examination and testing. We probably also want to just upgrade to sentry-sdk >=2.0.0,<3.0
. I think that’s ok since this only applies to the server, which is generally meant to run as a standalone app, rather than be used as a library.
Scopes now fork instead of stack. push_scope()
(which we use) is deprecated, and I’m worried some behaviors we do will no longer work correctly: inside the with
block, we set some things directly on the new scope, and some through the top-level SDK methods (actually I’m surprised this currently works, and don’t recall how we got to this state of affairs, even though it is probably my doing; it seems weird).
The Tornado integration requires Python 3.8+ and we currently support v3.7. (We don’t configure Sentry in CI, so we may not be seeing problems we would in production, or things are breaking silently.)
I believe the Internet Archive uses this server in conjunction with self-hosted Sentry, and v2 of the SDK is only compatible with Sentry server v20.6.0+. We need to check with them about changes here. (https://docs.sentry.io/platforms/python/migration/1.x-to-2.x#self-hosted)
Superseded by #177.
Updates the requirements on sentry-sdk to permit the latest version.
Release notes
Sourced from sentry-sdk's releases.
Changelog
Sourced from sentry-sdk's changelog.
... (truncated)
Commits
882ed7f
Updated changelogce89048
release: 2.0.1162773c
fix(integrations): Do not use convenience decorator (#3022)a626f01
Add Lambda function that deletes test Lambda functions (#2960)f5db9ce
Refactoring propagation context (#2970)d91a510
Usepid
for test database name in Django tests (#2998)534a301
test(tracing): Add tests for discarded transaction debug messages5aa7c9b
fix(tracing): Correct discarded transaction debug messagebda9deb
docs(tracing): Delete inaccurate comment6a73368
build(deps): bump checkouts/data-schemas from1e17eb5
to4aa14a7
(#2997)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show