Open weatherpattern opened 6 years ago
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.
Definitely still relevant!
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.
Added never-stale
label
This should mostly be about changing the CSS for html_diff_render
so that we treat <img>
elements (and probably other replaced elements, like <embed>
, <object>
, <audio>
, <video>
, <picture>
, <canvas>
, <svg>
, <math>
, and <iframe>
) specially.
Originally posted in: https://github.com/edgi-govdata-archiving/web-monitoring-ui/issues/204#issuecomment-367236238
Low priority (from Kendra) Sometimes a borders around new images is hard to pick up.
In this example, the red border gets broken up. Could there be a pink layer on top of it? We still pick the changes in the source views so I don't think this is a critical fix.
https://monitoring.envirodatagov.org/page/d6671efa-b085-4514-a394-fe38a562aed9/922ed6c7-526b-481d-8a37-7e5e02a89c23..841c3d81-c252-4a7e-bb6a-bc81ff35a4eb
Also Aaron found this case: https://monitoring.envirodatagov.org/page/ebbecab1-fd6d-483d-87f0-9098c4e40739/203d59d9-2f31-4ce8-829c-36c56d65c670..c0665c35-4c11-46aa-824f-549f74d89545