search

edgi-govdata-archiving / web-monitoring-ui

UI to enable analysts to quickly assess changes to monitored government websites
GNU General Public License v3.0
37 stars 38 forks source link

Don't require logging in #1037

Closed Mr0grog closed 1 year ago

Mr0grog commented 1 year ago

If the ALLOW_PUBLIC_VIEW config variable is set to true, the UI will no longer show a modal dialog requiring someone to be logged in before trying to browse any data. Having this work depends on the API actually allowing unauthenticated requests (at the time of writing, that's allowed in staging but not yet in production).

⚠️ This might break in weird ways! I need to do a once-over to make sure I covered all the obvious places we make assumptions about users, but it seems like we mostly did a good job not assuming anything. I will probably ship this just for staging pretty quickly, so I’m not marking it as a draft.

Fixes #1025.

Mr0grog commented 1 year ago

A quick review this morning looks good. Merging & deploying.