search

edgi-govdata-archiving / web-monitoring-ui

UI to enable analysts to quickly assess changes to monitored government websites
GNU General Public License v3.0
37 stars 38 forks source link

Migrate to React frontend framework #41

Closed lightandluck closed 7 years ago

lightandluck commented 7 years ago

The project is progressing from proof-of-concept to working application. We should migrate to a frontend framework such as React or Angular instead of jQuery to handle data binding and views.

kmcarter commented 7 years ago

I'd love to be involved with this part of the project. I don't yet have everything I need to see the demo in action, but I already have a few ideas for directions to take, from what I've been able to see.

AngularJS or Angular 2? (I'm learning AngularJS for work right now, so I'm pretty new to Angular in general).

dcwalk commented 7 years ago

Do we want to revisit https://github.com/edgi-govdata-archiving/webdiff-ui?

React (+ES6/2015) and Webpack with CSS Modules and Jest

...rather than rolling something from scratch?

lightandluck commented 7 years ago

Yes, this is definitely something that should be discussed and reach a consensus on. I'm also pretty new to modern tooling and frameworks so I'm not a good judge on what direction to take. @Mr0grog We discussed this briefly, you may have the most experience and can speak to a good architecture to use. I've only had experience with React, but Kelly, if you think you can migrate and help maintain the project in Angular, I support you working on it. We can discuss further after today's (3/11) standup meeting?

kmcarter commented 7 years ago

I will be at the standup, and I should have some time after to discuss further. I'll take a look at the webdiff-ui repo.

dcwalk commented 7 years ago

Also, could be good to look at the broader skills we have in the EDGI community: the Archivers.space app is react + meteor.

kmcarter commented 7 years ago

I'm a big proponent of using consistent tooling across an ecosystem where possible. I'm willing to learn React and Meteor to that end.

dcwalk commented 7 years ago

We had lots of React buy-in at our Weekly Stand up! @lightandluck do you all have a path forward?

lightandluck commented 7 years ago

@dcwalk Yes! I chatted with @agillette and @kmcarter separately after the meeting. I'm working on pruning the codebase of all dead code that's unnecessary, so they have less to wade through as they're reading it. Andy will take up migrating to React.

I gave Kelly an overview of the project, answered her questions, and she seems clear about the important aspects now. I'm sure I haven't been able to explain everything! But we believe she will be able to tackle #38 to start with, while getting familiar with the project as a whole.

dcwalk commented 7 years ago

Amazing, y'all are awesome :)

lightandluck commented 7 years ago

Rob is currently working on this. And we may drop Typescript because it was an artifact from the original project and causing issues. The tech stack will probably be React+Redux like Archivers 2.0

Mr0grog commented 7 years ago

@kmcarter sorry this discussion has been radio silent for a while. I’m trying to get a rough React implementation in this week (see #48) so others can start to build on it.

Talking w/ @lightandluck, it sounded like Typescript may have been a bit of a barrier for you before; do you think the project would be easier to get up and running on without it? (Still using React, though.)

lightandluck commented 7 years ago

@kmcarter Yes, our apologies, Kelly! I kind of fell off the map on this project as well. Just got re-involved 2 weeks ago. We'd be happy to have your help!