Add tests! (And turn on CircleCI)

edgi-govdata-archiving / web-monitoring-ui

UI to enable analysts to quickly assess changes to monitored government websites

GNU General Public License v3.0

37 stars 38 forks source link

Add tests! (And turn on CircleCI) #52

Closed Mr0grog closed 7 years ago

Mr0grog commented 7 years ago

I failed to get this done as part of #48, but we should set up:

Unit tests
Integration/browser tests
CircleCI support for the above

lazywithclass commented 7 years ago

@Mr0grog I followed the README but I am getting

GET http://web-monitoring-db.dev/api/v0/pages net::ERR_ICANN_NAME_COLLISION

and

TypeError: Failed to fetch

in the console, I am probably doing something silly. For example:

do I have to start the other two projects in order to see this one running ok?
is it ok to not change anything in .env?

Thanks and sorry if I missed something crucial

Mr0grog commented 7 years ago

Oh, you should not have:

WEB_MONITORING_DB_URL=http://web-monitoring-db.dev

In your .env file unless you actually have a server running there. If you specify nothing, you get the staging server (which is https://web-monitoring-db-staging.herokuapp.com), or you can set it to the production server (https://web-monitoring-db.herokuapp.com).

We should probably change the URL in the example .env file to point to staging, sorry :\

lazywithclass commented 7 years ago

Thanks for the prompt answer! That was it, I can work on the issue now.

lazywithclass commented 7 years ago

https://github.com/edgi-govdata-archiving/web-monitoring-ui/pull/70