search

edgurgel / httparrot

HTTP Request & Response Server. An incomplete clone of http://httpbin.org
https://httparrot.onrender.com/
MIT License
86 stars 27 forks source link

Update cowboy, make exjsx compatible with 3.0 or 4.0 #27

Closed ghost closed 7 years ago

ghost commented 7 years ago

I have started updating my projects, I have version requirements issues, I fix it's ok to have the project using more flexible version requirements.

edgurgel commented 7 years ago

I don't understand why we need to override here. Cowboy is a direct dependency and override is not needed AFAIK. Which version were you trying to use?

ghost commented 7 years ago

Actually I am ok with the cowboy version, but it's the exjsx that conflict with ex_coverall in my case.

edgurgel commented 7 years ago

I see. We should then expose to be exjsx ~> 3.0 or exjsx ~> 4.0 maybe? Then both will be supported. I'm almost 99% sure that override here won't be the actual solution. AFAIK override is for the user of a lib that wants to "set" the version no matter what the dependencies are defining. This shouldn't be part of the direct library AFAIK.

Having exjsx ~> 3.0 or ~> 4.0 would solve the problem?

ghost commented 7 years ago

Yes let's have exjsx ~> 3.0 or ~> 4.0 let me change my PR.

ghost commented 7 years ago

I didn't we can use ~> 3.0 or ~> 4.0 thanks I think I learn something useful.

edgurgel commented 7 years ago

Perfect 👍 I will release a new version soon (in 3-4 hours max)

ghost commented 7 years ago

Great thanks.

edgurgel commented 7 years ago

1.0.0 is out! https://github.com/edgurgel/httparrot/releases/tag/v1.0.0 Thanks for pushing this forward!