search

edgurgel / httparrot

HTTP Request & Response Server. An incomplete clone of http://httpbin.org
https://httparrot.onrender.com/
MIT License
86 stars 27 forks source link

Upgrading Tesla #38

Closed yordis closed 3 months ago

yordis commented 5 months ago

As requested @edgurgel

I am having some difficulty upgrading Tesla to OTP 26 and the httparrot SSL config, check the CI status: https://github.com/elixir-tesla/tesla/pull/623

I also tried to use OTP 25+ built-in public key certs stuff, but it didn't work, I am pretty sure something in the configuration is broken that I am failing to see.

I would appreciate some help with it.

edgurgel commented 4 months ago

Thanks, @yordis! Yeah we definitely need to update httparrot to run on newer Erlang and Elixir versions. Might need to review the SSL setup 🤔

yordis commented 3 months ago

It seems to be an SSL problem for sure, maybe the built-in certs needs to be updated or much better, using the OTP 25+ built-in functions to get the certs

nathany-copia commented 3 months ago

@edgurgel Any plans to update httparrot for Elixir 1.16?

I'm not sure how helpful I can be with certificate issues. 🤔

Also related, would you like the Travis CI config updated for newer versions of Elixir or switched to GitHub Actions?

edgurgel commented 3 months ago

I'm going to sort out this SSL issue this weekend! The help with the GitHub Actions will be great thank you

nathany-copia commented 3 months ago

Thanks @edgurgel.

nathany-copia commented 3 months ago

This issue can be closed.

https://github.com/elixir-tesla/tesla/pull/687 upgrades Tesla to httparrot 1.4, and all tests pass in Elixir 1.16.

Thanks again @edgurgel.

yordis commented 3 months ago

@edgurgel, for my sanity's sake, ideally, we should document how to generate those SSLs somewhere, at the very least some Make command, even though we may not have the private key.

Regardless, thank you so much for the help! I gain a few white hairs over SSL (classic)

edgurgel commented 3 months ago

Oh I just used https://github.com/FiloSottile/mkcert ! I intend to later on make it so that it can generate on boot so it never expires as mkcert's certificates expire after 2 years I think? :thinking: