search

edgurgel / httpoison

Yet Another HTTP client for Elixir powered by hackney
https://hex.pm/packages/httpoison
MIT License
2.22k stars 339 forks source link

Add the request!/1 function #473

Closed GuillaumeMilan closed 1 year ago

GuillaumeMilan commented 1 year ago

The request!/1 request was missing from the repository

edgurgel commented 1 year ago

Thanks! Would you mind adding some tests? Cheers!

GuillaumeMilan commented 1 year ago

Thanks! Would you mind adding some tests? Cheers!

Added some tests. But as the request function didn't had one I don't really know you want me to test (what is common between request and the other functions in the engine?)

edgurgel commented 1 year ago

Tests are good! We just need to mix format it now

GuillaumeMilan commented 1 year ago

Sorry I don't have the reflexe to trigger it Done 👍