edgurgel / httpoison

Yet Another HTTP client for Elixir powered by hackney
https://hex.pm/packages/httpoison
MIT License
2.22k stars 339 forks source link

The Base.request!/1 return value is not wrapped in a ok-tuple #481

Closed flambard closed 7 months ago

flambard commented 8 months ago

This PR is a fix of the typespec for Base.request!/1. The return value is not supposed to be wrapped in a ok-tuple.

mjquinlan2000 commented 8 months ago

For anyone also affected by dialyzer and waiting for this PR, you can add:

use HTTPoison.Base

@dialyzer {:nowarn_function, request!: 1}

to your modules that use HTTPoison.Base

edgurgel commented 7 months ago

2.2.1 is out! Thanks, team