edgurgel / solid

Liquid template engine in Elixir
https://hexdocs.pm/solid
MIT License
206 stars 39 forks source link

break and continue with whitespace control issue #86

Open edgurgel opened 3 years ago

edgurgel commented 3 years ago
     Render result was different!
     Input:
     ########################

     this should print

     {%- break -%}

     this should not print

     ########################

     code:  liquid_output == solid_output
     left:  "########################\n\nthis should print\n"
     right: "########################\n\nthis should print"
     Render result was different!
     Input:
     ########################

     this should print

     {%- continue %}

     this should not print

     ########################

     code:  liquid_output == solid_output
     left:  "########################\n\nthis should print\n"
     right: "########################\n\nthis should print"

https://github.com/edgurgel/solid/blob/master/test/integration/whitespace_control_cases/break_tag_test.exs#L3-L15 & https://github.com/edgurgel/solid/blob/master/test/integration/whitespace_control_cases/continue_tag_test.exs#L3-L15

carlosfrodrigues commented 3 years ago

I'd like to see this issue. Can you assign this for me?

edgurgel commented 3 years ago

Sure! Thanks! 🎉