Over writable configs - Githubissues

edgurgel / verk

A job processing system that just verks! 🧛‍

https://hex.pm/packages/verk

MIT License

721 stars 65 forks source link

Over writable configs #175

Closed tinenbruno closed 5 years ago

tinenbruno commented 5 years ago

This PR aims to solve issues #170 and #174.

Both max_retry_count and max_dead_jobs are now over writable by the client as they are no longer associated with a constant, thus evaluated on runtime.

Also this PR updates the documentation, using max_dead_jobs on the readme example configuration and explaining both these configurations on the modules they are used at.

coveralls commented 5 years ago

Coverage increased (+0.5%) to 88.358% when pulling 2c689d16b216618b4b534ac6cbc003e9e7e0f018 on tinenbruno:overwritable-configs into 9365c712bc4062d09cf78a397bcc09aaf1b7494c on edgurgel:master.

edgurgel commented 5 years ago

That's amazing work! Thank you so much, @tinenbruno 👌

I will merge and release a new version soon