fix(elixir): Fix unused vars, chunk_every

edgurgel / verk

A job processing system that just verks! 🧛‍

https://hex.pm/packages/verk

MIT License

721 stars 65 forks source link

fix(elixir): Fix unused vars, chunk_every #176

Closed raksonibs closed 5 years ago

raksonibs commented 5 years ago

While compiling, I had these deprecations:

Compiling 24 files (.ex)
warning: variable "reason" is unused
  lib/verk/queues_drainer.ex:49

warning: variable "shutdown_timeout" is unused
  lib/verk/queues_drainer.ex:49

warning: Enum.chunk/2 is deprecated. Use Enum.chunk_every/2 instead
  lib/verk/sorted_set.ex:82

I realize chunk is for older OTP versions. I assume the project doesn't want to deprecate until actually necessary?

coveralls commented 5 years ago

Coverage increased (+0.03%) to 87.917% when pulling 1373e520001a8a85d1a373ca9e67de7c8f01f15b on raksonibs:fix-outdated-elixir into 9365c712bc4062d09cf78a397bcc09aaf1b7494c on edgurgel:master.

edgurgel commented 5 years ago

TBH I think we will drop support to Elixir 1.4 soon so if you want to "unrevert" your last commit 😆

raksonibs commented 5 years ago

Done @edgurgel :)