Fixes Deprecation warnings for Elixir 1.8

edgurgel / verk

A job processing system that just verks! 🧛‍

https://hex.pm/packages/verk

MIT License

723 stars 65 forks source link

Fixes Deprecation warnings for Elixir 1.8 #182

Closed juddey closed 5 years ago

juddey commented 5 years ago

Hey Ed!

Heres the PR. All tests green on my 1.8 Elixir, but I haven't tested earlier versions. I'll shut #181 in the meantime. Thanks for making (and looking after) verk! :1st_place_medal:

edgurgel commented 5 years ago

Hey @juddey , thanks for the PR! 🎉

Do you know what's the impact for Elixir 1.6 and Elixir 1.7 once we fix the deprecated time unit warnings? Should they work with second and seconds ? 🤔

edgurgel commented 5 years ago

It seems to be an Erlang deprecation so it seems that it shouldn't impact directly which Elixir version is used 👌