Fix Verk.Job decode/1 - Githubissues

edgurgel / verk

A job processing system that just verks! 🧛‍

https://hex.pm/packages/verk

MIT License

721 stars 65 forks source link

Fix Verk.Job decode/1 #201

Closed alissonsales closed 4 years ago

alissonsales commented 4 years ago

It should only care about Verk.Job struct keys discarding any unknown keys.

This is a safer implementation for users that schedule jobs to Verk using ruby Sidekiq::Client.

A recent version of newrelic_rpm gem is injecting code into Sidekiq jobs for some sort of tracing/inspection making jobs scheduled with Sidekiq::Client invalid to Verk as they contain an unknown job key.

coveralls commented 4 years ago

Coverage remained the same at 88.312% when pulling d3b243ff0fe848c94cae6231e3fbff416e3f1547 on fix-job-decode into 79b0e794b5c470a6784e75cb8a304bf08f08a5f4 on master.

alissonsales commented 4 years ago

@edgurgel thanks :)