edheltzel / vscode-better-solarized

☯ A better Solarized theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=ginfuru.ginfuru-better-solarized-dark-theme
MIT License
43 stars 8 forks source link

Idea: use different colors for string delimiters and escape sequences #15

Closed andronocean closed 6 months ago

andronocean commented 3 years ago

Hey — firstly, thank you for creating this theme. It's really well done! I've been happily using it for a couple weeks, and this is the first time I've found something that annoys me.

Right now, the color scheme used to highlight escape sequences is the same as what's used for highlighting quotation marks at the start and end of strings. So, if I'm escaping quote marks within a string, it looks like it's the end of the string at a glance, unless I look closely.

Here's a PHP example (though it's the same in JS):

better-solarized-escapes

By comparison, here's how another theme (Monokai Pro) handles the same escapes:

monokai-pro-escape-coloring

It's a little thing, but this would be a lovely detail to include.

edheltzel commented 3 years ago

Let me see what I can do - I actually do use this theme as my daily driver.

I'm always open to PRs.

edheltzel commented 6 months ago

@andronocean here is a preview of the update:

Better Selenized Dark: better-selenized-dark

Better Solarized Dark (italic is the same): better-solarized-dark

andronocean commented 5 months ago

Oh that's awesome! A belated thank you for this.