edheltzel / vscode-better-solarized

☯ A better Solarized theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=ginfuru.ginfuru-better-solarized-dark-theme
MIT License
43 stars 8 forks source link

Correction to markdown list coloring #3

Closed linhtto closed 6 months ago

linhtto commented 6 years ago

This is a follow-up to https://github.com/ginfuru/vscode-better-solarized-dark/issues/1.

Thanks for the update!

I think there's a small typo: punctuation.definition.list.begin.markdown should actually be beginning.punctuation.definition.list.markdown. Right now there's no effect.

edheltzel commented 6 years ago

I'll take a peek at it... If you think you've got a fix PRs welcome and encouraged

linhtto commented 6 years ago

Unfortunately I have no experience. I was just guessing after noticing that it doesn't work for me, and looking at the scope name. But it seems to show up fine in the screenshot in #2 (the blue - for unordered list) so I'm not sure. For me there's still no coloring for either numbered or unordered lists.

edheltzel commented 6 years ago

@linhtto No worries

This is what I have for lists inside of Markdown: screen shot 2018-10-02 at 11 45 48 am