New bracket colors do not match the themes (Solarized Dark)

[sarpuser]

Hello,

The new bracket colors added to solarized dark as of commit 15ff6e59924a7e6a3072fc23d6693f5f4a3159e6 (5/10/24) are very different to the theme and in my opinion do not match at all. It is very disorienting to see all the whiteish brackets. I personally think these colors should either be changed back to the defaults or more closely aligned to the rest of the theme. If that is not possible, would you be able to provide me with the bracket color scheme that VSCode uses by default for other dark themes? It doesn't seem to be listed in any of the theme files on the VSCode GitHub.

Thanks

[edheltzel]

Can you take a screenshot and share it?

[sarpuser]

New:
vs Old (default in VSCode for dark themes, I think):

[edheltzel]

@sarpuser Thanks for that - the workspace UI originally just used the default off-the-shelf colors from VSCode. I agree that the new colors do seem off or out of order, but the change does follow the current default Solarized Dark workbench UI theme. I have no issues rolling those back or at least updating them to be more consistent.

in the meantime here are the default colors:

    "editorBracketHighlight.foreground1": "#FFD700",
    "editorBracketHighlight.foreground2": "#DA70D6",
    "editorBracketHighlight.foreground3": "#179fff",

[sarpuser]

I appreciate the quick response! Thank you for being open to looking into this. I do not know what colors the brackets should be to better fit the theme, but personally I think the default values look pretty good. I'll leave that decision to you.

[edheltzel]

@sarpuser would you mind trying these settings for Solarized Dark?

      "editorBracketHighlight.foreground1": "#B58900",
      "editorBracketHighlight.foreground2": "#D33682",
      "editorBracketHighlight.foreground3": "#268BD2",
      "editorBracketHighlight.foreground4": "#644EA0",
      "editorBracketHighlight.foreground5": "#2AA198",
      "editorBracketHighlight.foreground6": "#CB4B16",
      "editorBracketHighlight.unexpectedBracket.foreground": "#D30102",
      "editorBracketMatch.border": "#657B83A0",
      "editorBracketPairGuide.activeBackground1": "#B58900",
      "editorBracketPairGuide.activeBackground2": "#D33682",
      "editorBracketPairGuide.activeBackground3": "#268BD2",
      "editorBracketPairGuide.activeBackground4": "#644EA0",
      "editorBracketPairGuide.activeBackground5": "#2AA198",
      "editorBracketPairGuide.activeBackground6": "#CB4B16",