search

edheltzel / vscode-better-solarized

☯ A better Solarized theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=ginfuru.ginfuru-better-solarized-dark-theme
MIT License
43 stars 8 forks source link

Illegible terminal text #31

Closed scottinet closed 6 months ago

scottinet commented 6 months ago

Hi!

I was trying this theme, and I like it, except it has the same problem as the default Solarized Dark theme: some texts in the VSCode terminal are illegible due to their color being the same as the background one.

Here are a few screenshot to illustrate:

Better Solarized Dark

image

Better Selenized Dark (ok)

image

(for reference) Solarized Dark (default VSCode theme)

image

edheltzel commented 6 months ago

Thanks for catching this.

scottinet commented 6 months ago

Theming is not my forte (at all) so I won't submit a PR for this issue, but just in case, the culprit is terminal.ansiBlack which has the same value in both the Better Solarized Dark and Better Solarized Dark Italic themes than the terminal background color.

I forced it to a color I handpicked (randomly, sorry, I'm bad at this), near the background color, using this configuration:

  "workbench.colorCustomizations": {
    "terminal.ansiBrightBlack": "#454a4c"
  }

image

edheltzel commented 6 months ago

Appreciate it... I've fixed the values. I'll include this in the next release.