search

edi3 / edi3-json-ld-ndr

GNU General Public License v3.0
0 stars 2 forks source link

data types are not correctly reflected in schema:rangeIncludes property #47

Open onthebreeze opened 3 years ago

onthebreeze commented 3 years ago

I notice that almost all the properties in the graph have rangeIncludes xsd:string. but many of them are really numeric or dates or some other type. need to have a way to identify that type in the UML import or the subsequent openAPI will make them all strings instead of the right JSON type. we should at least make use of other xsd types like xsd:decimal, xsd:datetime etc - ie a more accurate mapping from CCTS data type to xsd data type.

also, is schema:rangeIncludes the right way to specify a data type? It assumes that a processor knows how to interpret a schema.org specific property (as opposed to an rdf property).

kshychko commented 3 years ago

@onthebreeze , this looks like a bug I introduced recently. I was checking the name and if it ends with Amount or Indicator etc. I was mapping it to xsd:decimal or xsd:boolean correspondingly.

onthebreeze commented 3 years ago

ok. If there's a CDT column in the source data that would be another way to do it.