edi3 / edi3-json-ld-ndr

GNU General Public License v3.0
0 stars 2 forks source link

Link edi3 vocabulary terms to the legacy CEFACT terms by UN id #8

Closed Fak3 closed 3 years ago

Fak3 commented 3 years ago

For those developers coming from the legacy CEFACT background it would be useful to have a way to learn the exact mapping of the class or property from the BSP/MMT Reference Data Model to the class or property in the edi3 vocabulary.

I propose we add edi3:cefactID property to our vocabulary. This property will be used to associate class or property with the Unique UN Assigned ID:

{
      "@id": "edi3:FinancialInstitutionAddress",
      "@type": "rdfs:Class",
      "rdfs:comment": "The location at which a financial institution may be found or reached.",
      "rdfs:label": "Financial Institution_ Address. Details",
      "edi3:cefactID": "UN01003173"
}

related to #4

nissimsan commented 3 years ago

@Fak3, I fail to understand the use case where this cefactID would be useful?

onthebreeze commented 3 years ago

I think the use case is vocabulary governance, not vocabulary usage. I've no doubt that we'll refine the NDR to make the target naming as clean as possible for example we might find rules to elimiate un-necessary verbosity in names so @id: "edi3:ConsignmentItemQuantity", becomes @id: "edi3:ReferencedConsignmentConsignmentItemQuantity",. But governance processes that accept feedback on the published output still need to be traceable back to the governed source.

for example - someone gives feedback on the publsihed output @id: "edi3:ConsignmentItemQuantity". But back int he RDM there are duplicates that we have eliminated - so they might say - "nice, but did you mean:

much simpler if the feedback includes edi3:cefactID: "UN01004196"

nissimsan commented 3 years ago

Agreed, @onthebreeze. Also, https://github.com/edi3/edi3-json-ld-ndr/issues/9 alone qualifies this requirement.

Fak3 commented 3 years ago

We chose approach described in #12 to add UN/CEFACT metadata. Closing.