search

edi9999 / jsqrcode

[deprecated] Lazarsoft's jsqrcode as a node module, object oriented, and with tests
Apache License 2.0
279 stars 63 forks source link

Test code cleanup #24

Closed Turbo87 closed 8 years ago

edi9999 commented 8 years ago

Hi, I prefer not to use the PNG.load method, but rather be explicit that we are reading the buffer from the filesystem

edi9999 commented 8 years ago

I think it would make sense to use eslint or something similar for that.

Turbo87 commented 8 years ago

@edi9999 I have a branch here that introduces ESLint, but I wanted to get the other stuff merged first ;)

edi9999 commented 8 years ago

Ok, please remove the PNG.load calls

Turbo87 commented 8 years ago

@edi9999 done

edi9999 commented 8 years ago

Thanks !