search

edi9999 / jsqrcode

[deprecated] Lazarsoft's jsqrcode as a node module, object oriented, and with tests
Apache License 2.0
278 stars 63 forks source link

Add ESLint support #25

Closed Turbo87 closed 8 years ago

edi9999 commented 8 years ago

Thanks. I'd like to keep the automated tests on v0.10.

Eslint 3.x is incompatible with node <4, so i would write in package.json :

https://www.npmjs.com/package/node-version-check

  "lint": "node-version-check \">=4\" && eslint . || node-version-check \"<4\""

Turbo87 commented 8 years ago

Thanks. I'd like to keep the automated tests on v0.10.

Eslint 3.x is incompatible with node <4

That's why I've used ESLint 2.x for now which still runs on Node 0.10 and above

edi9999 commented 8 years ago

Yes but you've removed 0.10 from the .travis.yml

I'd like at least 0.10, 0.12, 4,6

Turbo87 commented 8 years ago

I'd like at least 0.10, 0.12, 4,6

which is exactly what I did in https://github.com/edi9999/jsqrcode/pull/25/commits/cf5378221b0f772025f1a58ca0acc1051f50e1c4

edi9999 commented 8 years ago

Oh sorry, I misread the diff.

Thank we can merge.

Thanks a lot for the contribution !!