search

edi9999 / jsqrcode

[deprecated] Lazarsoft's jsqrcode as a node module, object oriented, and with tests
Apache License 2.0
278 stars 63 forks source link

Use Rollup for bundling #26

Closed Turbo87 closed 7 years ago

Turbo87 commented 7 years ago

Instead of just concatenating the files use ES6 modules and bundle them together using http://rollupjs.org/

This PR also improves performance a little by attaching the methods to the prototypes instead of recreating them in every constructor

Turbo87 commented 7 years ago

looks like rollup doesn't work on Node 0.x though... :-/

Turbo87 commented 7 years ago

Looks like we can use Node 6 for running rollup and then use the original Node version to test the output.

edi9999 commented 7 years ago

I would still like to generate the browser.js file (previously in the npm run complie:browser script).

So that the demo at https://github.com/edi9999/jsqrcode/blob/master/examples/browser-upload/index.html still works.

edi9999 commented 7 years ago

oh I see that you have changed the index.html too

edi9999 commented 7 years ago

Nice work @Turbo87 !

edi9999 commented 7 years ago

Oops, the readme is out of sync by merging ...

Turbo87 commented 7 years ago

@edi9999 sorry, forgot about the readme. are you planning for a new NPM release in the near future?

edi9999 commented 7 years ago

Yes, but not before Monday, I don't have a computer until than

edi9999 commented 7 years ago

I will notify you when it is released.

edi9999 commented 7 years ago

Released in 0.2.2 on npm