search

edi9999 / jsqrcode

[deprecated] Lazarsoft's jsqrcode as a node module, object oriented, and with tests
Apache License 2.0
278 stars 63 forks source link

Fix unnecessary circular dependency #28

Closed IagoLast closed 7 years ago

IagoLast commented 7 years ago

GF256poly was requiring GF256 only for using the addorsubstract function, now this funcion is defined in the GF256poly class so it has no dependencies

edi9999 commented 7 years ago

I think you can also remove the function from Gf256.

I agree that circular dependencies are bad sign, but duplication should also be avoided.

edi9999 commented 7 years ago

Up ?

I will close this as stale, but you can reopen this MR if you have corrected the code

IagoLast commented 7 years ago

Sorry I forgot about this, a new PR with a better fix has been created.