search

edi9999 / jsqrcode

[deprecated] Lazarsoft's jsqrcode as a node module, object oriented, and with tests
Apache License 2.0
280 stars 63 forks source link

Extraneous Parameters Passed #3

Closed Xanir closed 9 years ago

Xanir commented 9 years ago

A lot of method take in both image and qrcode.

As qrcode contains image it is not needed. A cleaner parameter would be to pass the original ImageData object acquired from the Canvas, or a single object that contains the array and the height / width

edi9999 commented 9 years ago

Altough i agree, i don't have time to change this. I would accept a pull request

edi9999 commented 9 years ago

Fixed for real now #5 , I won't close if it isn't from now