search

edi9999 / jsqrcode

[deprecated] Lazarsoft's jsqrcode as a node module, object oriented, and with tests
Apache License 2.0
278 stars 63 forks source link

Update callback to be error-first #30

Closed noahbass closed 7 years ago

noahbass commented 7 years ago

It would be great if the callback for the reader conformed to the javascript error-first convention.

So qr.callback = function(result, error) { /* ... */ } would become qr.callback = function(error, result) { /* ... */ }

edi9999 commented 7 years ago

Thanks, indeed, error first callbacks have been a standard since the beginning in Node. However, this is a major API change, and would also require a major version change. I will keep this MR for a while, and merge it when we can say we're ready for version 1.0

edi9999 commented 7 years ago

Can you please create a CHANGELOG file so that users will know what changed from 0.x and 1.x ?

noahbass commented 7 years ago

Added a changelog! I tried to stick to the guidelines at keepachangelog.com, but it's a very bare changelog at the moment.

edi9999 commented 7 years ago

Thanks !

rugk commented 7 years ago

Any news?

edi9999 commented 7 years ago

Merged into a new branch called v1

safeeeralshooog commented 5 years ago

hcthgu gf6i