edi9999 / jsqrcode

[deprecated] Lazarsoft's jsqrcode as a node module, object oriented, and with tests
Apache License 2.0
278 stars 63 forks source link

Offer web download without npm #38

Open rugk opened 7 years ago

rugk commented 7 years ago

Not everyone likes npm or even has it installed. Maybe someone would also just like to quickly use your lib or so and therefore it would be nice if the JS file(s) could also be offered as a simple download.

When doing this e.g. via CDNs or simply GItHub Pages one can even directly include it in the HTML page.

edi9999 commented 7 years ago

Maybe we can use https://github.com/cdnjs/cdnjs ?

Would you be interested in doing this request ?

rugk commented 7 years ago

GitHub pages would be enough IMHO, but it's your decision. I think there is not much to do except uploading… depending on where you publish it.

joonas-fi commented 7 years ago

I second this. I don't want any node.js or NPM stuff to bloat my host, so I had to build this inside a Docker container just to get the .js file out. Here's how I did it:

$ docker run --rm -it -v "$(pwd):/buildresult" node:7 bash
$ git clone https://github.com/edi9999/jsqrcode.git /work \
    && cd /work \
    && npm install \
    && npm run build \
    && cp dist/index.js dist/index.js.map /buildresult
papix2001 commented 7 years ago

yeahh do that easy like /LazarSoft/jsqrcode js files ready to be uploaded to the server no NPM or composer etc

edi9999 commented 7 years ago

Generated files do not belong in a git repository, the real solution is to use cdnjs, they are specialised in hosting js files for the browser

joonas-fi commented 7 years ago

Generated files don't belong in the repo I agree, but there should be a link to the built file. Or use Github releases for that (just like for compiled binaries)

On Jul 8, 2017 10:23, "Edgar Hipp" notifications@github.com wrote:

Generated files do not belong in a git repository, the real solution is to use cdnjs, they are specialised in hosting js files for the browser

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/edi9999/jsqrcode/issues/38#issuecomment-313840149, or mute the thread https://github.com/notifications/unsubscribe-auth/AAmdh7mNYk0sh6fIzswY1o0VDnuj57pmks5sLy6DgaJpZM4Mr8uv .