QRCode Classed defined on Window

edi9999 / jsqrcode

[deprecated] Lazarsoft's jsqrcode as a node module, object oriented, and with tests

Apache License 2.0

280 stars 63 forks source link

QRCode Classed defined on Window #4

Closed Xanir closed 9 years ago

Xanir commented 9 years ago

All of the classes defined within the library are defined on the Window. To ensure they do not cause conflict or pollute the Window object they should be contained within the qrcode object.

edi9999 commented 9 years ago

Altough i agree, i don't have time to change this. I would accept a pull request

Xanir commented 9 years ago

Closing this because you yourself cannot implement it does not seem fair as the issues itself is not resolved. I have been working on changes for this issue as well other changes to make the API more usable so I was also polling how active this project is.

edi9999 commented 9 years ago

Fixed for real on #5