search

edi9999 / jsqrcode

[deprecated] Lazarsoft's jsqrcode as a node module, object oriented, and with tests
Apache License 2.0
278 stars 63 forks source link

Invalid mode: 7 in (block:0 bit:3) #47

Closed adrianmarinica closed 6 years ago

adrianmarinica commented 6 years ago

Hey!

First off, great job with maintaining this project!

Secondly, I've stumbled on a small issue when trying to decode QR codes generated with zxing, Invalid mode: 7 in (block:0 bit:3).

I've found this issue mentioned in LazarSoft's repo, https://github.com/LazarSoft/jsqrcode/issues/33

In there, somebody proposes a simple solution, that I could easily PR, but before that, I wanted to know if you are aware of it, if you plan on adding that fix yourself, etc.

What do you think?

Thanks!

edi9999 commented 6 years ago

I haven't looked at the issue for now, but totally ok to merge a PR.

If possible, can you include a test that fails before the code change ?

adrianmarinica commented 6 years ago

Sorry for the late response. I have created a PR (https://github.com/edi9999/jsqrcode/pull/48) for this issue.

Checking out the first commit should demonstrate the issue, while the extra check added in the second commit should show how this issue would be solved.

If there is anything wrong with the code that should be changed, let me know and I will update the PR.

Thanks!

edi9999 commented 6 years ago

Thanks, looks good to me !

adrianmarinica commented 6 years ago

Awesome! Do you have plans for a new NPM release with this change?

edi9999 commented 6 years ago

I have just Released your bugfix in 1.0.4

adrianmarinica commented 6 years ago

Thanks!