edickie / ciftify

The tools of the Human Connectome Project (HCP) adapted for working with non-HCP datasets
https://edickie.github.io/ciftify/
MIT License
111 stars 156 forks source link

Pull request to fix issue #66 #67

Closed DESm1th closed 6 years ago

DESm1th commented 6 years ago

The first bug https://github.com/edickie/ciftify/issues/66 reports was caused by a missing comma in setup.py. The second was caused by ciftify/io.py hiding python's built-in io.py script (breaking functions like 'open'). As a bonus, I also fixed an unrelated broken link :)

DESm1th commented 6 years ago

Oh right, I stopped part way through updating those because you said you didnt want it named that. Have you decided on a final name?

edickie commented 6 years ago

let's go with niio for "neuroimaing input output"..Looks like there's nothing similar to that in PyPI...

On Wed, Jun 20, 2018 at 10:15 AM, Dawn E. Smith notifications@github.com wrote:

Oh right, I stopped part way through updating those because you said you didnt want it named that. Have you decided on a final name?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/edickie/ciftify/pull/67#issuecomment-398765143, or mute the thread https://github.com/notifications/unsubscribe-auth/AMl59pDjxiTVRChgklOeCbApS-pKnHZVks5t-lkMgaJpZM4UuWoY .

DESm1th commented 6 years ago

Ok, I've updated all the references to niio. Should be good now!