Remove test for server with null list of ciphers (https://null.badssl.com/) - newer version reject such connections without regard to cert verification options

edicl / drakma

HTTP client written in Common Lisp

http://edicl.github.io/drakma/

249 stars 58 forks source link

Remove test for server with null list of ciphers (https://null.badssl.com/) - newer version reject such connections without regard to cert verification options #109

Closed avodonosov closed 3 years ago

avodonosov commented 3 years ago

This test fails on all implementations when up to date OpenSSL is used. https://common-lisp.net/project/cl-test-grid/library/drakma.html

stassats commented 3 years ago

Maybe it should check for the error then?

avodonosov commented 3 years ago

No need, that's not part of CL wrapper around OpenSSL, that's pure OpenSSL logic.

The test was originally intended to verify one more time that different :verify values result in different behaviour. Today the :verify options are ignored, so the test makes no sense.

The remaining tests cover the :verify enough, so we are not really loosing anything.