search

edicl / drakma

HTTP client written in Common Lisp
http://edicl.github.io/drakma/
249 stars 58 forks source link

Use quri instead of puri #63

Closed tmccombs closed 9 years ago

hanshuebner commented 9 years ago

Nice, thanks! Has the required PURI pull request been merged and released to quicklisp?

tmccombs commented 9 years ago

It has been merged, I don't know if it has been released to quicklisp yet.

On Wed, Jul 8, 2015, 22:25 Hans Hübner notifications@github.com wrote:

Nice, thanks! Has the required PURI pull request been merged and released to quicklisp?

— Reply to this email directly or view it on GitHub https://github.com/edicl/drakma/pull/63#issuecomment-119812939.

tmccombs commented 9 years ago

yes it has been released to quicklisp

hanshuebner commented 9 years ago

Merged, thanks!

hanshuebner commented 9 years ago

Xach tried to compile the quicklisp dist with the new version of Hunchentoot and found many systems fail because they somehow depended on PURI:URI's being accepted or returned by HTTP-REQUEST or on PURI to be loaded as dependency of DRAKMA. It seems that it would be prudent to either fork DRAKMA for QURI support or to add a compatibility layer. For the time being, your changes had to be pulled back, sorry.

tmccombs commented 9 years ago

ok, it looks like I made some bad assumptions about how similar quri is to puri (for example puri returns a keyword for the scheme but quri returns a string). I will work on fixing those things. I don't thing hunchentoot actually depends on drakma using puri, my changes just broke drakma.