edificeio / entcore

ODE educational social network engine

Other

13 stars 5 forks source link

feat(admin): #WB-1069, add themed favicon to admin console #521

Closed jcbe-ode closed 3 weeks ago

jcbe-ode commented 3 weeks ago

Description

Admin console v2 was showing the default Angular icon. Now it displays the one from user's skin.

NE PAS MERGER, c'est pour une version future....

Fixes

Type of change

Please check options that are relevant.

[ ] Chore (PATCH)
[ ] Doc (PATCH)
[ ] Bug fix (PATCH)
[X] New feature (MINOR)

Which packages changed?

Please check the name of the package you changed

[X] admin
[ ] app-registry
[ ] archive
[ ] auth
[ ] cas
[ ] common
[ ] communication
[ ] conversation
[ ] directory
[ ] feeder
[ ] infra
[ ] portal
[ ] session
[ ] test
[ ] tests
[ ] timeline
[ ] workspace

Tests

Connect to /admin
Check the displayed icon in browser tab.

Reminder

Security flaws
Performance impacts (think bulk !)
Unit tests were replayed
Unit tests were added and/or changed
I have updated the reminder for the version including my modifications
[X] All done ! :smiley:

jcbe-ode commented 3 weeks ago

Revu par Romuald.