Closed Colelyman closed 2 months ago
This PR moves the prep_alleles_table function out of the plot_alleles_table function to minimize the amount of data copied over to other parallel processes. This makes it possible to analyze datasets with a large number of alleles with less memory.
prep_alleles_table
plot_alleles_table
@kclem there are some other places that we could make this change, namely in https://github.com/edilytics/CRISPResso2/blob/master/CRISPResso2/CRISPRessoCompareCORE.py#L409 but we don't use multiprocessing here, so it wouldn't change how much memory is used. Do you think we should refactor this as well?
This PR moves the
prep_alleles_tablefunction out of theplot_alleles_tablefunction to minimize the amount of data copied over to other parallel processes. This makes it possible to analyze datasets with a large number of alleles with less memory.@kclem there are some other places that we could make this change, namely in https://github.com/edilytics/CRISPResso2/blob/master/CRISPResso2/CRISPRessoCompareCORE.py#L409 but we don't use multiprocessing here, so it wouldn't change how much memory is used. Do you think we should refactor this as well?