search

edina / CuriousEdinburgh2

University of Edinburgh project developing a platform independent app for guided walking tours of sites of scientific and cultural interest in and around Edinburgh.
http://curiousedinburgh.org/
2 stars 1 forks source link

Tour Record Display Page - View Videos #55

Open gmh04 opened 7 years ago

gmh04 commented 7 years ago

Display videos on Tour Record page.

NicolaOsborne commented 7 years ago

Moving this to next milestone. Android issue: needs video to play full screen when tapped (As in iOS).

gmh04 commented 7 years ago

No fullscreen support for WebView on Android: https://github.com/facebook/react-native/issues/5230.

gmh04 commented 7 years ago

@NicolaOsborne could investigate 3rd party plugins, e.g: https://github.com/inProgress-team/react-native-youtube

NicolaOsborne commented 7 years ago

Thanks @gmh04. React Native YouTube looks promising and is the code every enquiry online seems to point to. Happy to go with this.

gmh04 commented 7 years ago

Unable to get this plugin working for android, see https://github.com/inProgress-team/react-native-youtube/issues/99. The solution to use an alternative fork ended with the app crashing. By the way, this plugin also requires the native android youtube app to be installed.

@NicolaOsborne with our timescales I would suggest leaving the video player as it is without full screen support on android, at least it works - with no dependency on another native app.

NicolaOsborne commented 6 years ago

Could you please recheck if there is now YouTube support available? (for roadmap)