Closed perllaghu closed 3 years ago
Currently the nbgrader plugin exchange.py code has
exchange.py
base_service_url = Unicode( os.environ.get("NAAS_BASE_URL", "https://noteable.edina.ac.uk") ).tag(config=True) def service_url(self): this_url = urljoin(self.base_service_url, "/services/nbexchange/") self.log.debug(f"service_url: {this_url}") return this_url
and the exchange app.py has
app.py
for handler in handlers.default_handlers: for url in handler.urls: self.handlers.append((url_path_join(self.base_url, url), handler))
(where base_url = os.environ.get("JUPYTERHUB_SERVICE_PREFIX", "/services/nbexchange/")
base_url = os.environ.get("JUPYTERHUB_SERVICE_PREFIX", "/services/nbexchange/")
This was all built assuming the exchange was a service managed by the hub, rather than a separate thing.
This needs to be revisited.
This has been addressed.... it's the same as issues #25 & #26
Currently the nbgrader plugin
exchange.py
code hasand the exchange
app.py
has(where
base_url = os.environ.get("JUPYTERHUB_SERVICE_PREFIX", "/services/nbexchange/")
This was all built assuming the exchange was a service managed by the hub, rather than a separate thing.
This needs to be revisited.