edina / nbexchange

External exchange for nbgrader
Other
6 stars 2 forks source link

Update environment variable name that the nbexchange notebook plugin uses to talk to nbexchange #25

Closed agxs closed 3 years ago

agxs commented 4 years ago

The notebook plugin uses an environment variable called NAAS_BASE_URL and defaults to https://noteable.edina.ac.uk. This isn't appropriate for a shared plugin as its a bit too Noteable specific, and it's not accurate really.

This variable should be renamed to NBEXCHANGE_BASE_URL and default to http://nbexchange:9000. This is a more accurate name for what the variable is used for.

We need to sync up the noteable-api when this env variable name changes as it's currently passed to notebooks.

perllaghu commented 3 years ago

This is a duplicate of #26