search

edina / nbexchange

External exchange for nbgrader
Other
6 stars 2 forks source link

Fix tests #30

Closed perllaghu closed 4 years ago

perllaghu commented 4 years ago

This was tested in a private cluster, and works.

The feedback code should find assignments restricted to the current course (and be active), and timestamps no longer try to be clever ('cos that's what was killing the linking from submissions-table to downloaded sub-directory)

Feel free to critique & ask questions and/or push back for changes

codecov[bot] commented 4 years ago

Codecov Report

Merging #30 (b373feb) into master (d22152c) will increase coverage by 14.00%. The diff coverage is 57.36%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #30       +/-   ##
===========================================
+ Coverage   62.76%   76.77%   +14.00%     
===========================================
  Files          41       42        +1     
  Lines        1958     2067      +109     
===========================================
+ Hits         1229     1587      +358     
+ Misses        729      480      -249
Impacted Files Coverage Δ
nbexchange/dbutil.py 54.65% <ø> (ø)
nbexchange/handlers/assignment.py 78.39% <ø> (-0.11%) :arrow_down:
nbexchange/handlers/collection.py 88.67% <ø> (-0.11%) :arrow_down:
nbexchange/handlers/submission.py 79.10% <ø> (ø)
nbexchange/models/assignments.py 91.83% <0.00%> (ø)
nbexchange/models/courses.py 80.48% <0.00%> (ø)
nbexchange/models/subscriptions.py 89.28% <0.00%> (ø)
nbexchange/models/users.py 78.37% <0.00%> (-2.71%) :arrow_down:
nbexchange/plugin/course.py 0.00% <0.00%> (ø)
nbexchange/plugin/noteable_auth.py 0.00% <0.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bfecbd8...b373feb. Read the comment docs.