search

edina / nbexchange

External exchange for nbgrader
Other
6 stars 2 forks source link

Replace noteable api request with jwt cookie check #49

Closed agxs closed 3 years ago

agxs commented 3 years ago

Instead of going back to Noteable to authorise the user, we can directly check the jwt cookie to make sure it's valid. Just decoding the cookie is enough to validate the time and hash etc.

codecov[bot] commented 3 years ago

Codecov Report

Merging #49 (4b9334e) into master (732605e) will increase coverage by 0.00%. The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   76.76%   76.76%           
=======================================
  Files          43       43           
  Lines        2096     2092    -4     
=======================================
- Hits         1609     1606    -3     
+ Misses        487      486    -1
Impacted Files Coverage Δ
nbexchange/handlers/auth/naas_user_handler.py 75.00% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 732605e...4b9334e. Read the comment docs.